jens-scheffler-bosch commented on PR #35252: URL: https://github.com/apache/airflow/pull/35252#issuecomment-1784274264
> > Termination log is just "one" thin but I now just realized that all venv script input, output, logs and temp files are also created in the venv cache folder. This is bad and a problem because multiple different functions in parallel might use the cache. So we get into a real concurrency issue! > > Yes. When I looked at this todya, I **thought** the lock we have is for the whole execution, but yeah. I just checked, we do it only for venv creation time. Which makes much more time. > That concurrency thing was one important detail. The lock is only being made during creation of the venv. Once the cached venv is available of course we want and need to be able to execute tasks in the venv concurrently. Same like with external python. But reading comments in #35258 hope it is okay to revert the termination log fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
