Lee-W commented on code in PR #35226:
URL: https://github.com/apache/airflow/pull/35226#discussion_r1376255346


##########
tests/providers/amazon/aws/operators/test_batch.py:
##########
@@ -305,40 +337,55 @@ def test_monitor_job_with_logs(
 
 
 class TestBatchCreateComputeEnvironmentOperator:
+    @pytest.fixture(autouse=True)
+    def setup_test_cases(self):

Review Comment:
   > It is pytest's builtin replacement for xunit-style setup / teardown with 
additional beneficials, like use another fixtures without some hacks
   
   Yep, this is why I'm not sure whether this is something we want according to 
the document. I'm actually good with such things, but just want to make sure. 
If this is what we want, should we update the doc to reduce confusion?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to