vincbeck commented on code in PR #35160:
URL: https://github.com/apache/airflow/pull/35160#discussion_r1376782819
##########
airflow/settings.py:
##########
@@ -205,13 +205,31 @@ def configure_vars():
DONOT_MODIFY_HANDLERS = conf.getboolean("logging",
"donot_modify_handlers", fallback=False)
+class SkipDBTestsSession:
+ """This fake session is used to skip DB tests when
`_AIRFLOW_SKIP_DB_TESTS` is set."""
+
+ def __init__(self):
+ raise RuntimeError(
+ "Accessing DB while `_AIRFLOW_SKIP_DB_TESTS` is set. Mark test or
class "
+ "with `@pytest.mark.db_test` or whole module with `pytestmark =
pytest.mark.db_test`."
+ )
+
+ def remove(*args, **kwargs):
+ pass
+
+
def configure_orm(disable_connection_pool=False, pool_class=None):
"""Configure ORM using SQLAlchemy."""
from airflow.utils.log.secrets_masker import mask_secret
- log.debug("Setting up DB connection pool (PID %s)", os.getpid())
- global engine
global Session
+ global engine
+ if os.environ.get("_AIRFLOW_SKIP_DB_TESTS") == "true":
+ # Skip DB initialization if in unit tests where they DB tests are
skipped
Review Comment:
```suggestion
# Skip DB initialization if, in unit tests, DB tests are skipped
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
