dolfinus opened a new pull request, #34331: URL: https://github.com/apache/airflow/pull/34331
<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> <!-- Please keep an empty line above the dashes. --> --- * Deploy Airflow using Heml chart 1.10.0 with `dags.gitSync.enabled=True` * After testing git sync is working as expected, set `dags.persistence.enabled=true` to store dags to persistent volume instead of empty dir. * Got exception that `git-sync-ssh-key` volume is missing in `scheduler` pod description: ``` volumes: - name: config configMap: name: airflow-airflow-config - name: dags - emptyDir: {} - - - name: git-sync-ssh-key - secret: - secretName: airflow-ssh-secret - defaultMode: 288 + persistentVolumeClaim: + claimName: airflow-dags - name: logs persistentVolumeClaim: ``` ``` cannot patch "airflow-scheduler" with kind Deployment: Deployment.apps "airflow-scheduler" is invalid: [spec.template.spec.containers[1].volumeMounts[1].name: Not found: "git-sync-ssh-key", spec.template.spec.initContainers[1].volumeMounts[1].name: Not found: "git-sync-ssh-key"] helm.go:84: [debug] cannot patch "airflow-scheduler" with kind Deployment: Deployment.apps "airflow-scheduler" is invalid: [spec.template.spec.containers[1].volumeMounts[1].name: Not found: "git-sync-ssh-key", spec.template.spec.initContainers[1].volumeMounts[1].name: Not found: "git-sync-ssh-key"] ``` [helm.log](https://github.com/apache/airflow/files/12595699/helm.log) This is because of wrong condition in helm chart - `git-sync-ssh-key` `volumeMount` is always present in `git-sync` container inside scheduler pod, but corresponding `volume` is added to pod only if `dags.persistence.enabled=false`. Changed this condition to always add `git-sync-ssh-key` to scheduler volumes if git sync is enabled and ssh-key secret is passed to chart. This issue was introduced in #22913 - git sync should be disabled on all pods if dag persistence is enabled, **except** scheduler (because scheduler pod is the sync point of dags). **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org