jiajie-chen commented on issue #35227:
URL: https://github.com/apache/airflow/issues/35227#issuecomment-1788126499
@hakuno
Thanks for the advice. I did see that `workers.strategy.rollingUpdate` has a
default value set, while `scheduler.strategy` was set to `~`. This led me to
try to recreate the issue and submit a ticket.
Trying with `--set 'workers.strategy.rollingUpdate={}'` raised the same
`INSTALLATION FAILED` error from Helm.
I also tried `--set 'workers.strategy.rollingUpdate=null'` which *did* work.
However, I think it would be nice to have consistent configuration defaults
for `strategy`.
It can be confusing to remember that:
- `workers`/`triggerer`/`dagProcessor` have a default `strategy`, so use
Helm's merge semantics to delete `strategy.rollingUpdate` if needed
- `scheduler`/`webserver` has a null default `strategy`
- `scheduler` by default will omit `strategy` from `Deployment.spec`
- `webserver` by default will use [a specific `rollingUpdate` value in
`Deployment.spec`](https://github.com/apache/airflow/blob/helm-chart/1.11.0/chart/templates/webserver/webserver-deployment.yaml#L53-L72),
but doesn't support merging values into this default `rollingUpdate`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
