potiuk commented on PR #35181: URL: https://github.com/apache/airflow/pull/35181#issuecomment-1789083878
> @potiuk I believe that is unnecessary complicating things as not all process are opening stats socket before daemonize, > plus there can be different impl we need to take care and will make things tightly coupled with stats in cli Correct we would have to get the list of sockets to retain and make sure they are open. And yes, if there are no side effect of the Statsd opening/closing sockets quickly - it's a waste of resources but very small so we could trade-off simplicity of the solution for the waste (and make sure there are really no side effects) - maybe the Statsd will manage to do something before closing the socket and say we will have some side effects ? As long as we check the side effects and are reasonably sure they are none, even the 'imperfect' solution is 'good enough'. Have you looked at the potential side effects @pavansharma36 ? Are you pretty sure there are none ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
