Joffreybvn commented on PR #32319:
URL: https://github.com/apache/airflow/pull/32319#issuecomment-1789191930

   PR is ready for review.
   
   Currently:
   - Implements a new `_make_serializable` method in the DbApiHook, which can 
be overidden by maintainers to make result of `cursor.fetch()` serializable
   - Implement this _make_serializable method in the ODBCHook, which returns by 
default Row objects (C++ objects, not serializable) - making the XCom backend 
crash when returning result of a Select
   - Implement this _make_serializable method in the DatabricksSqlHook, and 
remove the [fix previously implemented in the Databricks 
Operator]((https://github.com/apache/airflow/pull/31780).
   
   I also added a static checks: It raises an error when a subclass of 
DbApiHook overrides `_make_serializable`, but depends on common.sql providers 
which do not implement yet this method. Current implementation assumes that the 
version where this PR will be added into common.sql is `1.8.1`.
   
   Here is a preview before bumping the providers' version:
   ![Screenshot from 2023-11-01 
15-23-12](https://github.com/apache/airflow/assets/17571457/2a58f955-893a-47d8-8695-09cccf9db45b)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to