Taragolis commented on PR #35360: URL: https://github.com/apache/airflow/pull/35360#issuecomment-1789716824
> This is a breaking change where it could fail the Mypy test for the users who already subclass the DAG class. Not sure that static check could be counted as breaking change, runtime code would still work. I see also a complaining about migration to SA 2.0 compatible syntax also breaks someone static checks. Anyway right now this change breaks our static checks 😒 > my team has a great experience with a custom DAG class used to simplify creating dags by multiple teams I use the Factories for the same approach without inheritance, different users different use cases and expectations. Someone might expects that DAG methods could be overwritten. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
