hakuno opened a new pull request, #35362: URL: https://github.com/apache/airflow/pull/35362
closes: https://github.com/apache/airflow/issues/35227 Currently, these values don't support Recreate type. - `workers.strategy.type=Recreate` - `triggerer.strategy.type=Recreate` - `dagProcessor.strategy.type=Recreate` Ps. When it's `persistence.enabled=false`, the `strategy` is used on **Deployment** kind. But it's failing. Because there have default values as below: ``` ... strategy: rollingUpdate: maxSurge: "100%" maxUnavailable: "50%" ``` So the `rollingUpdate` node cannot be mixed with `type` other than `RollingUpdate`. # The tests ### Workers ``` # pytest helm_tests/airflow_core/test_worker.py::TestWorker::test_deployment_strategy =================================================================== test session starts ==================================================================== platform linux -- Python 3.8.18, pytest-7.4.3, pluggy-1.3.0 -- /usr/local/bin/python cachedir: .pytest_cache rootdir: /opt/airflow configfile: pyproject.toml plugins: requests-mock-1.11.0, xdist-3.3.1, anyio-4.0.0, instafail-0.5.0, rerunfailures-12.0, timeouts-1.2.1, asyncio-0.21.1, mock-3.12.0, icdiff-0.8, httpx-0.21.3, time-machine-2.13.0, cov-4.1.0 asyncio: mode=strict setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s collected 4 items helm_tests/airflow_core/test_worker.py::TestWorker::test_deployment_strategy[Recreate-strategyUpdate0] PASSED [ 25%] helm_tests/airflow_core/test_worker.py::TestWorker::test_deployment_strategy[Recreate-None] PASSED [ 50%] helm_tests/airflow_core/test_worker.py::TestWorker::test_deployment_strategy[RollingUpdate-strategyUpdate2] PASSED [ 75%] helm_tests/airflow_core/test_worker.py::TestWorker::test_deployment_strategy[RollingUpdate-None] PASSED [100%] ==================================================================== 4 passed in 26.44s ==================================================================== ``` ### Triggerer ``` # pytest helm_tests/airflow_core/test_triggerer.py::TestTriggerer::test_deployment_strategy =================================================================== test session starts ==================================================================== platform linux -- Python 3.8.18, pytest-7.4.3, pluggy-1.3.0 -- /usr/local/bin/python cachedir: .pytest_cache rootdir: /opt/airflow configfile: pyproject.toml plugins: requests-mock-1.11.0, xdist-3.3.1, anyio-4.0.0, instafail-0.5.0, rerunfailures-12.0, timeouts-1.2.1, asyncio-0.21.1, mock-3.12.0, icdiff-0.8, httpx-0.21.3, time-machine-2.13.0, cov-4.1.0 asyncio: mode=strict setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s collected 4 items helm_tests/airflow_core/test_triggerer.py::TestTriggerer::test_deployment_strategy[Recreate-strategyUpdate0] PASSED [ 25%] helm_tests/airflow_core/test_triggerer.py::TestTriggerer::test_deployment_strategy[Recreate-None] PASSED [ 50%] helm_tests/airflow_core/test_triggerer.py::TestTriggerer::test_deployment_strategy[RollingUpdate-strategyUpdate2] PASSED [ 75%] helm_tests/airflow_core/test_triggerer.py::TestTriggerer::test_deployment_strategy[RollingUpdate-None] PASSED [100%] ==================================================================== 4 passed in 26.41s ==================================================================== ``` ### DAG Processor ``` # pytest helm_tests/airflow_core/test_dag_processor.py::TestDagProcessor::test_deployment_strategy =================================================================== test session starts ==================================================================== platform linux -- Python 3.8.18, pytest-7.4.3, pluggy-1.3.0 -- /usr/local/bin/python cachedir: .pytest_cache rootdir: /opt/airflow configfile: pyproject.toml plugins: requests-mock-1.11.0, xdist-3.3.1, anyio-4.0.0, instafail-0.5.0, rerunfailures-12.0, timeouts-1.2.1, asyncio-0.21.1, mock-3.12.0, icdiff-0.8, httpx-0.21.3, time-machine-2.13.0, cov-4.1.0 asyncio: mode=strict setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s collected 4 items helm_tests/airflow_core/test_dag_processor.py::TestDagProcessor::test_deployment_strategy[Recreate-strategyUpdate0] PASSED [ 25%] helm_tests/airflow_core/test_dag_processor.py::TestDagProcessor::test_deployment_strategy[Recreate-None] PASSED [ 50%] helm_tests/airflow_core/test_dag_processor.py::TestDagProcessor::test_deployment_strategy[RollingUpdate-strategyUpdate2] PASSED [ 75%] helm_tests/airflow_core/test_dag_processor.py::TestDagProcessor::test_deployment_strategy[RollingUpdate-None] PASSED [100%] ==================================================================== 4 passed in 31.11s ==================================================================== ``` Thanks in advance, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
