pubudu91 commented on code in PR #35397: URL: https://github.com/apache/airflow/pull/35397#discussion_r1382605196
########## airflow/providers/atlassian/jira/notifications/jira.py: ########## @@ -0,0 +1,83 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +from functools import cached_property +from typing import Any + +from airflow.exceptions import AirflowOptionalProviderFeatureException +from airflow.providers.atlassian.jira.hooks.jira import JiraHook + +try: + from airflow.notifications.basenotifier import BaseNotifier +except ImportError: + raise AirflowOptionalProviderFeatureException( + "Failed to import BaseNotifier. This feature is only available in Airflow versions >= 2.6.0" + ) + + +class JiraNotifier(BaseNotifier): + """ + Jira notifier for creating Jira issues upon failures. + + :param jira_conn_id: The HTTP connection ID for the Jira instance. + :param description: The content for the body of the issue + :param summary: The title of the issue + :param project_id: The ID of the project under which the issue will be created + :param issue_type_id: The ID of the issue category + :param labels: The labels to be applied to the issue + """ + + template_fields = ("description", "summary", "project_id", "issue_type_id", "labels") + + def __init__( + self, + *, + jira_conn_id: str = JiraHook.default_conn_name, + proxies: Any | None = None, + description: str, + summary: str, + project_id: int, + issue_type_id: int, + labels: list[str] = [], Review Comment: Ack. Added it since the labels list is not getting modified within the notifier. But I guess avoiding it altogether and assigning an empty list as you've suggested is better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
