ephraimbuddy commented on code in PR #35421:
URL: https://github.com/apache/airflow/pull/35421#discussion_r1383500061


##########
airflow/api_connexion/endpoints/forward_to_fab_endpoint.py:
##########
@@ -79,12 +79,14 @@ def delete_role(**kwargs) -> APIResponse:
 @_require_fab
 def patch_role(**kwargs) -> APIResponse:
     """Update a role."""
+    kwargs.pop("body", None)

Review Comment:
   If you test the endpoints: `api/v1/roles` and `api/v1/users` with post/patch 
calls they will fail with the above errors.
   
   Kwargs contains all your request args which are now forwarded to the 
`role_and_permission_endpoint.patch_role`. That's where the body is coming 
from. it's the request.json
   
   You can test `api/v1/roles` and `api/v1/users` directly in the current main 
to see the error. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to