Taragolis commented on code in PR #35244:
URL: https://github.com/apache/airflow/pull/35244#discussion_r1386686826
##########
airflow/providers/apache/druid/hooks/druid.py:
##########
@@ -163,8 +167,8 @@ class DruidDbApiHook(DbApiHook):
conn_name_attr = "druid_broker_conn_id"
default_conn_name = "druid_broker_default"
- conn_type = "druid"
- hook_name = "Druid"
+ conn_type = "druid_broker"
Review Comment:
The problem that `DruidDbApiHook` use `DbApiHook` and this might be the
single place outside of the UI where `conn_type` also matter. And it could be
hard, but not impossible to make it by backward compatible. Better just keep
`conn_type="druid"` since it required almost zero effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
