jedcunningham commented on PR #35185: URL: https://github.com/apache/airflow/pull/35185#issuecomment-1803252298
My best guess is that this is what is failing: https://github.com/apache/airflow/blob/9356233762a67c0a787fc3e16040455019af13bd/airflow/example_dags/example_kubernetes_executor.py#L152-L160 I see nothing in the repo that is provisioning that namespace in kind. If we merge this, we need to update this doc: [https://github.com/apache/airflow/blob/9356233762a67c0a787fc3e16040455019af13bd/do[…]cs/apache-airflow/core-concepts/executor/kubernetes.rst?plain=1](https://github.com/apache/airflow/blob/9356233762a67c0a787fc3e16040455019af13bd/docs/apache-airflow/core-concepts/executor/kubernetes.rst?plain=1#L137) I think it’d be worth adding more coverage to [this test](https://github.com/apache/airflow/blob/9356233762a67c0a787fc3e16040455019af13bd/tests/providers/cncf/kubernetes/test_pod_generator.py#L342) to make sure things like the dag_id etc that Airflow sets wins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
