sinwoobang commented on PR #35551: URL: https://github.com/apache/airflow/pull/35551#issuecomment-1804022963
@potiuk Thank you for the review. I looked around Great Expectations as per your request. Pydantic V2 has been supported on Great Expectations since 8th Sep according to this commit https://github.com/great-expectations/great_expectations/commit/091fc1dd472ef17a39b41bd0f9b8486869d695c7, whereas the PR - bringing back Pydantic V1 compatibility - was created on 5th Sep. Facts - Great Expectations has supported Pydantic V2 from [the release 0.17.15](https://github.com/great-expectations/great_expectations/releases/tag/0.17.15) published on 8th Sep. - However, Great Expectations still supports Pydantic from v1.10.8 - `requirements.txt` says that [v1.9.2](https://github.com/great-expectations/great_expectations/blob/091fc1dd472ef17a39b41bd0f9b8486869d695c7/requirements.txt#L23) is the min version, which is NOT true. - A maintainer confirms that [v1.10.8](https://github.com/great-expectations/great_expectations/pull/8604/commits/4d80172511f53247e6599565f3f719eaae51d40e) is the actual min version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
