dstandish commented on PR #35392: URL: https://github.com/apache/airflow/pull/35392#issuecomment-1804880615
Yeah maybe Bas misunderstood what this PR does. I'll let him comment. Re configurability, I'm making a general point. For example see this PR https://github.com/apache/airflow/pull/34231. Author thought logs were too chatty while waiting for pod to start. So make it configurable with a new param. I think, as a general tendency, we are too quick to always add more configuration. In this case, alternatively, we could have just increased the time to 2 seconds, or 5 seconds. That would seem better to me. So just making a general comment here, we should probably be less eager to lean on "just make it configurable" as a solution. Before adding configuration options, we should make sure we evaluate whether it's really worth it, whether it's not well-enough achievable with other strategies. And sometimes we should just change to new behavior (and deprecate the old behavior) rather than keep both forever -- this is the sentiment that Bas expressed that resonated with me and which I was trying to express support for. Whether it really applies here, I'll have to take a closer look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
