hussein-awala commented on code in PR #35560:
URL: https://github.com/apache/airflow/pull/35560#discussion_r1390036087
##########
airflow/providers/http/operators/http.py:
##########
@@ -162,16 +163,16 @@ def execute(self, context: Context) -> Any:
def execute_sync(self, context: Context) -> Any:
self.log.info("Calling HTTP method")
response = self.hook.run(self.endpoint, self.data, self.headers,
self.extra_options)
- response = self.paginate_sync(first_response=response)
+ response = self.paginate_sync(response=response)
return self.process_response(context=context, response=response)
- def paginate_sync(self, first_response: Response) -> Response |
list[Response]:
+ def paginate_sync(self, response: Response) -> Response | list[Response]:
if not self.pagination_function:
- return first_response
+ return response
- all_responses = [first_response]
+ all_responses = [response]
while True:
- next_page_params = self.pagination_function(first_response)
+ next_page_params = self.pagination_function(response)
if not next_page_params:
break
response =
self.hook.run(**self._merge_next_page_parameters(next_page_params))
Review Comment:
Ah yes, the response value is updated after each iteration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
