uranusjr commented on PR #35598: URL: https://github.com/apache/airflow/pull/35598#issuecomment-1808110999
I think the problem is, what does an ObjectStoragePath mean in a database context? Since most databases have a flatter and more structured hierarchy (you can only store in a table/collection/whatever, they are bundled in one database/schema, and that’s about it), I feel `spark.connect` in your example taking a path would be confusing enough on it own. And if ObjectStoragePath can only be used against limited kinds of storage, should it still have such a generic name? > P.S. If we are talking databases I would rename `protocol` to `dialect`. Also, I'm not overly charmed by using `Database.default` I would just use `Database(dialect=xxx)` to allow for default connections (as does ObjectStoragePath). The problem I have designing this is, a lot of the time people would probably want to pass in a connection ID instead, but allowing both `Database(dialect=...)` and `Database(conn_id=...)` but not both requires some type-time and run-time gymnastics that I don’t see the point. I’d sacrifice some ergonomics here for explicitness and simplicity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
