eladkal commented on code in PR #35091:
URL: https://github.com/apache/airflow/pull/35091#discussion_r1391424179


##########
airflow/providers/microsoft/azure/hooks/synapse_pipeline.py:
##########


Review Comment:
   In Airflow we use [mixed governance model for 
providers](https://github.com/apache/airflow/blob/main/PROVIDERS.rst#id9) which 
means that the company behind the provider have shared responsibility over it. 
Sadly in case of Microsoft the Azure team is not involved (Unlike Google and 
Aws) as a result we have no way of knowing what is Azure stand point of this 
subject.
   In that case my point of view is to "fallback" to the common practice of how 
we do things in other providers - you can see for example the effort we did in 
Amazon/Aws https://github.com/apache/airflow/issues/20139 to have organized 
files where the motivation is ease of find.
   
   So in the case in front of us and given the information you shared I still 
think we should use `synapse.py`.
   
   I welcome Azure team to be more involved in the project should they decide 
to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to