dstandish commented on code in PR #32977:
URL: https://github.com/apache/airflow/pull/32977#discussion_r1397820932


##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -84,6 +85,32 @@ def get_es_kwargs_from_config() -> dict[str, Any]:
     return kwargs_dict
 
 
+def _ensure_ti(ti: TaskInstanceKey | TaskInstance, session) -> TaskInstance:

Review Comment:
   @pankajkoti this is duplicated from FileTaskHandler
   
   if we import from core, then we have to bump major
   
   also, i don't like to create public interface when we can avoid it
   
   now it's a little code duplication, but it's private so we can remove it at 
will.
   
   @uranusjr might have comment. this is the bit of code that originally i put 
as class method under TI key



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to