Bisk1 commented on code in PR #35712: URL: https://github.com/apache/airflow/pull/35712#discussion_r1397916362
########## airflow/providers/apache/livy/hooks/livy.py: ########## @@ -575,10 +575,11 @@ def _generate_base_url(self, conn: Connection) -> str: if conn.host and "://" in conn.host: base_url: str = conn.host else: - # schema defaults to HTTP - schema = conn.schema if conn.schema else "http" + scheme = conn.conn_type Review Comment: I see. In that case, do you think it would make sense to change connections as follows: - register `https` as a separate connection type which inherits from HTTP with the only difference in `conn_type` so that it becomes visible in UI - for other hooks based on HttpHook, make them use connections of type `http` and `https` instead of custom types. I understand that these integrations need custom hook implementations, but what is the point of creating a custom connection type for every hook type? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org