Bisk1 commented on code in PR #35712: URL: https://github.com/apache/airflow/pull/35712#discussion_r1398011645
########## airflow/providers/apache/livy/hooks/livy.py: ########## @@ -575,10 +575,11 @@ def _generate_base_url(self, conn: Connection) -> str: if conn.host and "://" in conn.host: base_url: str = conn.host else: - # schema defaults to HTTP - schema = conn.schema if conn.schema else "http" + scheme = conn.conn_type Review Comment: Anyway, I see that this change is bigger in scope than I thought and I can see how it could be controversial so I probably need a devlist vote on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org