potiuk opened a new pull request, #35746:
URL: https://github.com/apache/airflow/pull/35746
When running test with pytest-xdist, tests can be executed in random order
in multiple workers. This means that if a test leaves a side-effect, it might
affect another test.
The `recalculate_patterns` fixture in "test_serde" had such a side effect
and caused #35699 to happen.
It was used in order to clear the cache BEFORE the test so that it could
reload the patterns using different configugration provided by the test as new
configuration.
The side effect of it was hawever that after the test completed, the new
configuration remained in the cache AFTER the test has been completed - thus is
the xdist worked started a test that rely on the cache containting "regular"
value, it - surpisingly - got the value that was read from the special
configuration provided by the previous test.
This PR fixes it by clearing the cache also AFTER the test has completed,
which means that any other test running in the same worker will refresh the
test again - with the configuration it is supposed to have. This is done with
try/finally pattern, because context manager / yield will not execute the
post-yield code when an exception is thrown, so if there is a failed assertion,
the cache_clear afer yield might not happen and such `cache_clear` test that
fails might still cause cache pollution.
Fixes: #35699
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
