amoghrajesh commented on code in PR #35748:
URL: https://github.com/apache/airflow/pull/35748#discussion_r1398696229
##########
chart/templates/workers/worker-deployment.yaml:
##########
@@ -98,6 +98,9 @@ spec:
{{- toYaml $podAnnotations | nindent 8 }}
{{- end }}
spec:
+ {{- if and (semverCompare ">=2.8.0" .Values.airflowVersion)
.Values.workers.kerberosSidecar.enabled }}
Review Comment:
Since this is a new feature that works in conjunction to #35548, i have kept
it to have a semver check
##########
chart/templates/workers/worker-deployment.yaml:
##########
@@ -98,6 +98,9 @@ spec:
{{- toYaml $podAnnotations | nindent 8 }}
{{- end }}
spec:
+ {{- if and (semverCompare ">=2.8.0" .Values.airflowVersion)
.Values.workers.kerberosSidecar.enabled }}
Review Comment:
For now, the `shareProcessNamespace` is kept under `kerberosSidecar` section
to keep it tied to kerberos. It can be moved out to workers section in case it
has another use case in the near future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
