ginolegigot commented on PR #35136: URL: https://github.com/apache/airflow/pull/35136#issuecomment-1819606385
Hey! I think i understood how to setup a proper airflow dev environment, launch tests and I think my unit test even though it might not optimal at least is functional (first time i code unit test). One more point, usually an impersonation chain is chosen in google operators, so either a service acount email as a string might be used or a list of strings of service account emails. Given the particular nature of the ComputeEngineSSHHook, (at least in my understanding), it creates a shell command based on gcloud. And I don't know how to pass multiple service accounts to the "--impersonate-service-account=" argument. I did not test yet (so maybe it's trivial) but i'm not sure that's the scope of this PR. I'm opened to discuss it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
