romsharon98 commented on code in PR #35362:
URL: https://github.com/apache/airflow/pull/35362#discussion_r1402957838
##########
chart/templates/_helpers.yaml:
##########
@@ -995,3 +995,11 @@ capabilities:
app: keda-operator
{{- end }}
{{- end }}
+
+{{- define "deployment_strategy" }}
+ {{- if and .strategy.type (eq .strategy.type "Recreate") }}
Review Comment:
If the user still want to use rolling update strategy and log.persistent =
True, what u did here will prevent him to do so although it works.
Maybe u should check if the log is persistent u dont need to change the
strategy.
Or maybe just change the default strategy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
