dashton90 commented on PR #35790:
URL: https://github.com/apache/airflow/pull/35790#issuecomment-1825027155

   > Cool. I'll see if I can find documentation around which sizes DO work, but 
at least we have a place to start now.
   
   The supported instances are listed 
[here](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/hibernating-prerequisites.html#hibernation-prereqs-supported-instance-families)
   
   > What do you think about the unit tests? Do they need to be tweaked?
   
   If the logs are not making it then the tests should definitely be updated. I 
did add two unhappy path unit tests for trying to hibernate instances not 
configured for hibernation 
[1](https://github.com/apache/airflow/pull/35790/files#diff-04a8f0131e1098782c138b484b4e563bcda622b1442371be798eeef95d004a55R267)
 
[2](https://github.com/apache/airflow/pull/35790/files#diff-04a8f0131e1098782c138b484b4e563bcda622b1442371be798eeef95d004a55R293).
   
   > We (the AWS Airflow team) run most of the example_{foo} tests in the 
system test folder on a regular basis and report the results 
[here](https://aws-mwaa.github.io/#/open-source/system-tests/dashboard.html). 
The logs aren't publicly available (yet??), unfortunately, but you can see a 
pass/fail for the last 10 runs there.
   
   Amazing, I'll keep an eye on this page next time I contribute :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to