potiuk commented on issue #35806:
URL: https://github.com/apache/airflow/issues/35806#issuecomment-1826430516

   Yes. Very good analysis (thanks), however I believe it has some flawed 
assumptions. 
   
   I would love to get some more insights on that one and I have two questions 
@dlesco
   
   Question 1) What is a (reasonable and deliberate and well thought) reason 
you would like to limit CPU on triggerer? 
   
   For me it makes no sense whatsoever. Triggerer - by definition - runs an 
active async-io loop and again - by-definition it should run as fast as humanly 
possible to run this (single) async-io loop. And it's main async-io loop will 
take no more than 1 CPU (again almost by definition - because the async-io loop 
is just this - active loop. No threads, no multi-processing, just run your 
triggers as fast as you can. And if you do not have triggers, in the queue it 
will not take CPU - almost at all. 
   
   So literally IMHO it makes no sense to allocate 0.5 or less CPU to 
triggerer. What purpose would it serve? Could you please elaborate on why you 
would want to set the limit for triggerer?
   
   So IMHO at most this issue should end up in (hopefully you could contribute 
it) with some production guideline documentation to never set the CPU limit to 
triggerer to < 1 (it was not specified - but your observation is right that 
setting it to lower limit will result in some unexpected results, so it would 
be great - if we agree that it's the case in the discussion - that you submit - 
as a way to contribute back - an update to documentation explaining it. But 
maybe I am wrong and there are good reasons why you would like to deliberately 
set it to 0.5 for example (I do not see it currently).
   
   Question 2) What is your proposal on solving it if you do not agree with my 
understanding explained in 1 ? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to