jscheffl commented on PR #35719:
URL: https://github.com/apache/airflow/pull/35719#issuecomment-1826935842

   > > I really _love_ the UI changes gradually migrating from legacy to new.
   > > When I tested locally I saw still the old link pointing to the old XCom 
page in the second row of Task details in Grid. As below. 
![image](https://private-user-images.githubusercontent.com/95105677/284401641-cd8bf228-36e6-4e50-97fd-f9f567836a80.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDEwMzA4NDAsIm5iZiI6MTcwMTAzMDU0MCwicGF0aCI6Ii85NTEwNTY3Ny8yODQ0MDE2NDEtY2Q4YmYyMjgtMzZlNi00ZTUwLTk3ZmQtZjlmNTY3ODM2YTgwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzExMjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMTI2VDIwMjkwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYwMmJlN2ViMTYyODg1YjdmOWU3NmZkZjg5OTk3NjJmZTZmOWY3NDg0OTcyZWY1ODk4OGZmZjcyY2RlN2U4OTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.gC_JVDf622MWU15Scf4MeLX8m1wSZkASH63i6PPWmp8)
   > > Can you remove this and redirect the route from `/xcom` to the grid 
sub-page as well?
   > > As release 2.8.0 is just about to be cut, if finished it might still be 
elegible into the next version, would be cool.
   > 
   > I have removed the link from the Details tab in Grid view. 
![image](https://private-user-images.githubusercontent.com/148540755/285685052-ba52545c-3daa-497c-bb8b-50f45ddb4683.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDEwMzk1NzgsIm5iZiI6MTcwMTAzOTI3OCwicGF0aCI6Ii8xNDg1NDA3NTUvMjg1Njg1MDUyLWJhNTI1NDVjLTNkYWEtNDk3Yy1iYjhiLTUwZjQ1ZGRiNDY4My5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBSVdOSllBWDRDU1ZFSDUzQSUyRjIwMjMxMTI2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDIzMTEyNlQyMjU0MzhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xNjRkMzZjM2UwMTQyZTJkOTMxNjBhN2Y5OTFjMjA3Mzc3NTM5ZDNmM2M1ZmI0ZmQyMmQwZTlhYjhjYmViNWIyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.8kR9mpsd7346RwE4Y3T-THrAjEWPMg3drnFnH-frE-k)
   > 
   > However, I have not added redirect for `/xcom`. I still see the `/task`, 
`/rendered-template`, `/log` endpoints being available. Any suggestions on 
whether I should remove the xcom tab here entirely or we leave it as is similar 
to log. There are no direct links from grid view to this page as far as I know 
and we only get to this page via the "More Detail" button 
![image](https://private-user-images.githubusercontent.com/148540755/285685200-f3b48a6d-40c9-4b42-a294-c81a683064e9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDEwMzk1NzgsIm5iZiI6MTcwMTAzOTI3OCwicGF0aCI6Ii8xNDg1NDA3NTUvMjg1Njg1MjAwLWYzYjQ4YTZkLTQwYzktNGI0Mi1hMjk0LWM4MWE2ODMwNjRlOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBSVdOSllBWDRDU1ZFSDUzQSUyRjIwMjMxMTI2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDIzMTEyNlQyMjU0MzhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jODQ
 
1ZmJkYjlhM2YwODRmYjJmZTQ3OTJjOTE5MTYzM2FhZDYyZDk2ZDJmN2QyNjFhY2MwMjZiYjUxZmY1NTUxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.KnezxmeyLhKm71gyZFcsViZNAaXBaAOMsUIddWiEwOw)
   
   I'd propose to remove the other link. Would it be possible to redirect the 
`/xcom` route like `/code` to the new view?
   (But my proposal is just "my" opinion, how about the others?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to