potiuk commented on PR #34137: URL: https://github.com/apache/airflow/pull/34137#issuecomment-1833566575
> Here i asked if something else needed fix Well. The CI tells you what needs to be fixed. I think you should take a look at the contributor's guide and understand that fixing and rebasing CI is what is the "first pass". You have one PR to submit. We regularly review 100s of PR a day. And CI and tests are the way to automate thing that must be fixed before we do next pass of reviews. So my comment - while it had been expressed with brevity - reflect the state -of matter. you need to fix tests before we move any furtther. In case it is not clear - it's all described in our contributor's guide: * How to communicate (where it is written that it's author's responsiblity to mae sure their PR gets reviewed - including periodoc rebasing and followin up on it) https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#how-to-communicate * How to prepare PR: https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#step-4-prepare-pr * How to iterate on PR: https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#step-5-pass-pr-review I understand it's a lot of information to digest, so I perfectly understand your lack of understanding how our PR process looks like and what is expected from author, but now that you got it explained in a little more than "tests need fixing" I hope you will continue contributing and follow those guidelines. I think also what helps is understand that it's you who want to contribute something to the project, so it's a good idea to pay attention to your own PR and if in doubt consult the documentation. Looking forward to your future contributions. No hard feelings from my side, I hope with those explanations you will understand why the ball was on your side all the time, you just did not follow up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
