vchiapaikeo commented on code in PR #35403:
URL: https://github.com/apache/airflow/pull/35403#discussion_r1410869863


##########
airflow/www/static/js/api/useGridData.ts:
##########
@@ -105,6 +105,7 @@ const useGridData = () => {
       };
       const response = await axios.get<AxiosResponse, GridData>(gridDataUrl, {
         params,
+        paramsSerializer: { indexes: null },

Review Comment:
   
[useMarkTaskDryRun](https://github.com/apache/airflow/blob/main/airflow/www/static/js/api/useMarkTaskDryRun.ts#L81-L83)
 looked a little suspicious to me (useClearTaskDryRun also has a similar 
forEach loop). However, in the UI, I couldn't find a request that would return 
multiple map_index. I also did some manual UI testing and watched network calls 
and couldn't find any array-like ones. I think we are good.
   
   <img width="1470" alt="image" 
src="https://github.com/apache/airflow/assets/9200263/16ba1644-4615-41d5-8e44-ea2ae9d2a5c6";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to