potiuk commented on PR #35791: URL: https://github.com/apache/airflow/pull/35791#issuecomment-1835835446
I don't think hardcoding it to 1 second is a good idea. it sounds pretty magical. Also it has potentially undesireable side effects - there might be cases where the retry is actually good if it happens quickly. If we want to do add anything like that, I'd say we should have a configuration option telling whether to delay retries or not and how long. Also it is generally a bad idea to have a fixed hard-coded value - ideally there should be a way to get at least a bit of exponential back-off and make several retries with increasing delay period - and we should be able to configure both initlal delay, number of retries and exponential back-off factor. We can use tenacity for that - we already use it for similar purposes. I think if this is done this way - with configurable retries, exponential backoff (and unit tests as well) - then we could merge it I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
