ephraimbuddy commented on code in PR #35983:
URL: https://github.com/apache/airflow/pull/35983#discussion_r1411923562
##########
airflow/providers/weaviate/hooks/weaviate.py:
##########
@@ -94,18 +93,14 @@ def get_conn(self) -> WeaviateClient:
url=url, auth_client_secret=auth_client_secret,
additional_headers=additional_headers
)
+ @cached_property
def get_client(self) -> WeaviateClient:
Review Comment:
> yep, what I meant is something like
>
> ```python
> @cached_property
> def conn(...):
> ```
I think we shouldn't depreccate since there's no convention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
