potiuk commented on code in PR #36003:
URL: https://github.com/apache/airflow/pull/36003#discussion_r1412015133
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -1368,19 +1369,18 @@ def release_prod_images(
f"{dockerhub_repo}:{airflow_version}-python{python}",
f"{dockerhub_repo}:latest-python{python}",
)
- if python == DEFAULT_PYTHON_MAJOR_MINOR_VERSION:
- # only tag latest "default" image when we build default python
version
- # otherwise if the non-default images complete before the default
one, their jobs will fail
- if slim_images:
- alias_image(
- f"{dockerhub_repo}:slim-{airflow_version}",
- f"{dockerhub_repo}:slim-latest",
- )
- else:
- alias_image(
- f"{dockerhub_repo}:{airflow_version}",
- f"{dockerhub_repo}:latest",
- )
+ if python == ALLOWED_PYTHON_MAJOR_MINOR_VERSIONS[-1]:
Review Comment:
BTW. I also found that this if was wrongly indented (but since we always
ran one job per python version in CI, it was not discovered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
