hussein-awala commented on code in PR #36000:
URL: https://github.com/apache/airflow/pull/36000#discussion_r1412018906


##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -144,7 +144,7 @@ class DbApiHook(BaseHook):
     # Override with db-specific query to check connection
     _test_connection_sql = "select 1"
     # Override with the db-specific value used for placeholders
-    placeholder: str = "%s"
+    _placeholder: str = "%s"

Review Comment:
   This could be moved to `__init__` since it's no longer a class attribute.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to