pankajkoti commented on code in PR #36023:
URL: https://github.com/apache/airflow/pull/36023#discussion_r1412801677
##########
.pre-commit-config.yaml:
##########
@@ -33,7 +33,7 @@ repos:
- id: doctoc
name: Add TOC for Markdown and RST files
files:
-
^CONTRIBUTING\.md$|^README\.md$|^UPDATING.*\.md$|^chart/UPDATING.*\.md$|^dev/.*\.md$|^dev/.*\.rst$
+
^CONTRIBUTING\.md$|^README\.md$|^UPDATING.*\.md$|^chart/UPDATING.*\.md$|^dev/.*\.md$|^dev/.*\.rst$|^.github/.*\.md
Review Comment:
This TOC would be helpful!!
##########
.github/SECURITY.md:
##########
@@ -32,56 +43,90 @@ around its features. If you have any concern around Airflow
Security or believe
you have uncovered a vulnerability, we suggest that you get in touch via the
e-mail address
[secur...@airflow.apache.org](mailto:secur...@airflow.apache.org).
+Before sending the report, however, please read the following guidelines
first. The guidelines should
+answer the most common questions you might have about reporting
vulnerabilities.
+
+### What should be and should NOT be reported ?
+
**Only** use the security e-mail address to report undisclosed security
vulnerabilities in Apache
Airflow and to manage the process of fixing such vulnerabilities. We do not
accept regular
bug reports or other security-related queries at this address. We will ignore
mail
sent to this address that does not relate to an undisclosed security problem
in the Apache Airflow project. Please follow regular communication channels
described in
-the [Airflow Community](https://airflow.apache.org/community/index.html) page
for
-inquiries, questions and other discussions related to the process or issues.
+the [Airflow Community](https://airflow.apache.org/community/index.html) page
for inquiries, questions and other discussions related
+to the process or issues.
+
+Specifically, we will ignore results of security scans that contain a list of
dependencies of Airflow
+with dependencies in Airflow Docker reference image - there is a page that
describes how the
+[Airflow reference Image is fixed at release
time](https://airflow.apache.org/docs/docker-stack/index.html#fixing-images-at-release-time)
and providing helpful instructions explaining
+how you can build your own image and manage dependencies of Airflow in your
own image.
-Specifically, we will ignore results of security scans that contain a list of
-dependencies of Airflow with dependencies in Airflow Docker reference image -
there
-is a page that describes how the
-[Airflow reference Image is fixed at release
time](https://airflow.apache.org/docs/docker-stack/index.html#fixing-images-at-release-time)
-and providing helpful instructions explaining how you can build your
-own image and manage dependencies of Airflow in your own image.
+### How to report the issue ?
Please send one plain-text email for each vulnerability you are reporting
including an explanation
of how it affects Airflow security. We may ask that you resubmit your report
if you send it as an image,
movie, HTML, or PDF attachment when you could as easily describe it with plain
text.
-Before reporting vulnerabilities, please make sure to read and understand the
-[security
model](https://airflow.apache.org/docs/apache-airflow/stable/security/security_model.html)
of Airflow, because
-some of the potential security vulnerabilities that are valid for projects
that are publicly accessible
-from the Internet, are not valid for Airflow.
+### Is this really a security vulnerability ?
+Before reporting vulnerabilities, please make sure to read and understand the
[security
model](https://airflow.apache.org/docs/apache-airflow/stable/security/security_model.html)
+of Airflow, because some of the potential security vulnerabilities that are
valid for projects that are
+publicly accessible from the Internet, are not valid for Airflow.
Airflow is not designed to be used by untrusted users, and some trusted users
are trusted enough to do a
variety of operations that could be considered as vulnerabilities in other
products/circumstances.
-Therefore, some potential security vulnerabilities do not apply to Airflow, or
have a different severity
-than some generic scoring systems (for example `CVSS`) calculation suggests.
Severity of the issue is
-determined based on the criteria described in the
-[Severity Rating blog post](https://security.apache.org/blog/severityrating/)
by the Apache Software
-Foundation Security team.
-The [Airflow Security
Team](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#security-team)
will get back to you after assessing the report.
-If you wish to know more about the ASF security process, the
-[ASF Security team's page](https://www.apache.org/security/) describes
-how vulnerability reports are handled in general by all ASF projects, and
includes PGP keys if
-you wish to use them when you report the issues.
+Again. Please make sure to read and understand the [security
model](https://airflow.apache.org/docs/apache-airflow/stable/security/security_model.html)
+of Airflow - this might help to save your time for reporting and our time for
assessing the issues when
+they are clearly expected, according to the Security model. You also avoid
disappointment when you spend
+a lot of time on preparing the issue report to follow the guidelines above and
what you get as a response is
+"this is not a security issue" or "this is invalid security issue" or "this is
expected behaviour". You
+save time for yourself and for the Airflow Security team by reading and
understanding the security model
+before reporting the issue.
-## Security vulnerabilities in Airflow and Airflow community managed providers
+### How do we assess severity of the issue ?
+
+Severity of the issue is determined based on the criteria described in
+the [Severity Rating blog
post](https://security.apache.org/blog/severityrating/) by the Apache Software
Foundation Security team.
+
+Due to reasons explained in the previous chapter, some potential security
vulnerabilities
+do not apply to Airflow, or have a different severity than some generic
scoring systems
+(for example `CVSS`) calculation suggests. So we are not using any generic
scoring system.
+
+
+### What happens after you report the issue ?
+
+The [Airflow Security
Team](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#security-team)
will get back to you after assessing the report. You will usually get
+confirmation that the issue is being worked (or that we quickly assessed it as
invalid) within several
+business days. Note that this is an Open-Source projects and members of the
security team are volunteers
+so please make sure to be patient. If you do not get a response within a week
or so, please send a
+kind reminder to the security team. We will usually let you know the CVE
number that will be assigned
+to the issue and the severity of the issue as well as release the issue is
scheduled to be fixed
+after we assess the issue (which might take longer or shorter time depending
on the issue complexity and
+potential impact, severity, whether we want to address a whole class issues in
a single fix and a number
+of other factors). You should subscribe and monitor the
`us...@airflow.apache.org` mailing
Review Comment:
```suggestion
of other factors). You should subscribe and monitor the
`us...@airflow.apache.org` mailing
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
