jscheffl commented on code in PR #36025:
URL: https://github.com/apache/airflow/pull/36025#discussion_r1412846228
##########
airflow/www/static/js/dag/details/taskInstance/Logs/index.tsx:
##########
@@ -193,24 +197,44 @@ const Logs = ({
{tryNumber !== undefined && (
<>
<Box>
- <Text as="span"> (by attempts)</Text>
- <Flex my={1} justifyContent="space-between">
- <Flex flexWrap="wrap">
- {internalIndexes.map((index) => (
- <Button
- key={index}
- variant={taskTryNumber === index ? "solid" : "ghost"}
- colorScheme="blue"
- onClick={() => setSelectedTryNumber(index)}
- data-testid={`log-attempt-select-button-${index}`}
- >
- {index}
- </Button>
- ))}
- </Flex>
- </Flex>
+ {!showDropdown && (
+ <Box>
+ <Text as="span"> (by attempts)</Text>
+ <Flex my={1} justifyContent="space-between">
+ <Flex flexWrap="wrap">
+ {internalIndexes.map((index) => (
+ <Button
+ key={index}
+ variant={taskTryNumber === index ? "solid" : "ghost"}
+ colorScheme="blue"
+ onClick={() => setSelectedTryNumber(index)}
+ data-testid={`log-attempt-select-button-${index}`}
+ >
+ {index}
+ </Button>
+ ))}
+ </Flex>
+ </Flex>
+ </Box>
+ )}
<Flex my={1} justifyContent="space-between" flexWrap="wrap">
<Flex alignItems="center" flexGrow={1} mr={10}>
+ {showDropdown && (
+ <Box width="100%" mr={2}>
+ <Select
+ placeholder="Select log attempt"
Review Comment:
Can you apply a small nit, such that the size is matching the other
dropdowns? Otherwise I tested and looks good! Even if you just restart the 10th
time you see the UI immediately switching.
```suggestion
size="sm"
placeholder="Select log attempt"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
