dstandish commented on code in PR #35887:
URL: https://github.com/apache/airflow/pull/35887#discussion_r1416622944
##########
airflow/models/dag.py:
##########
@@ -848,16 +848,35 @@ def date_range(
return [info.logical_date for info in it]
def is_fixed_time_schedule(self):
+ """Figures out if the schedule has a fixed time (e.g. 3 AM every day).
+
+ Detection is done by "peeking" the next two cron trigger time; if the
+ two times have the same minute and hour value, the schedule is fixed,
+ and we *don't* need to perform the DST fix.
+
+ This assumes DST happens on whole minute changes (e.g. 12:59 -> 12:00).
+
+ Do not try to understand what this actually means. It is old logic that
+ should not be used anywhere.
+ """
warnings.warn(
"`DAG.is_fixed_time_schedule()` is deprecated.",
category=RemovedInAirflow3Warning,
stacklevel=2,
)
- try:
- return not self.timetable._should_fix_dst
- except AttributeError:
+
+ from airflow.timetables._cron import CronMixin
+
+ if not isinstance(self.timetable, CronMixin):
return True
+ from croniter import croniter
+
+ cron = croniter(self.timetable._expression)
+ next_a = cron.get_next(datetime.datetime)
+ next_b = cron.get_next(datetime.datetime)
+ return next_b.minute == next_a.minute and next_b.hour == next_a.hour
Review Comment:
if it's not used anywhere, and should not be used anywhere, why make a
change to it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
