uranusjr commented on code in PR #35820:
URL: https://github.com/apache/airflow/pull/35820#discussion_r1416991356
##########
airflow/io/store/__init__.py:
##########
@@ -134,6 +146,6 @@ def attach(
if store := _STORE_CACHE.get(alias):
return store
- _STORE_CACHE[alias] = store = ObjectStore(protocol=protocol,
conn_id=conn_id, fs=fs)
+ _STORE_CACHE[alias] = store = ObjectStore(protocol=protocol,
conn_id=conn_id, fs=fs, **kwargs)
Review Comment:
It makes me uncomfortable that storage options are only effective in the
first call to `attach`; in later calls they will be silently ignored, even when
options in the existing storage object does not match. It would be more
explicit (thus less prone to user errors) if storage creation and retrieval
should be splitted into two functions instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
