potiuk commented on code in PR #36084:
URL: https://github.com/apache/airflow/pull/36084#discussion_r1417273983


##########
airflow/providers/openlineage/plugins/facets.py:
##########
@@ -63,7 +67,9 @@ class UnknownOperatorInstance(RedactMixin):
     properties: dict[str, object]
     type: str = "operator"
 
-    _skip_redact: list[str] = ["name", "type"]
+    # openlineage-python<=1.5.0 does not annotate this as ClassVar
+    # mypy may complain about overriding instance variable with class variable
+    _skip_redact: ClassVar[list[str]] = ["name", "type"]  # type: ignore

Review Comment:
   ```suggestion
       _skip_redact: ClassVar[list[str]] = ["name", "type"]  # type: 
ignore[misc]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to