josh-fell commented on PR #30176: URL: https://github.com/apache/airflow/pull/30176#issuecomment-1844102050
> Disabke it by default add ad parameter is_templated? > > WHY? > > I think the reason why we want it templated is to allow people to convert old operators easily but I think with python return value - f-string is more natural way and we should encourage that rather than Jinja Add a parameter might add some confusion. The current implementation will be able to read a templated Bash script out of the box and there could be Jinja expressions in its contents. But would users be confused about needing to add `is_templated_cmd` parameter when using a script? Right now, no, but they would if they returned a string from the function that was templated. Maybe we just handle it and the authoring experience is less specialized and consistent between these use cases. DAG authors can write the command/script they way they need it to run. It's possible DAG authors are implementing tasks from other folks who aren't involved in the Airflow implementation (e.g. a security engineer wanting to orchestrate a series of commands that a data engineer (the DAG author in this scenario) enriches to make idempotent and better fit into an Airflow context). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
