eladkal commented on issue #36057: URL: https://github.com/apache/airflow/issues/36057#issuecomment-1848450007
> Actually @eladkal , wondering if the above is sufficient for what you need... the problem is that the action_logging decorator only logs a single row for both a single delete (if you click on the trash button at the row level - event = dagrun.delete) and multiple deletes (if you click on Actions > Delete - event = action_muldelete). When a delete is issued, we only get the pk(s) and there is no dag_id passed back to the webserver. > > I'm not sure if breaking action_logging to log multiple records on these bulk actions is a good idea here and prefer to keep it as is. What I might be more amenable to is if there is a single delete for a single dag_id, maybe we can get its dag_id and pass it into params. Wdyt? The end goal is to see that delete action was taken on dagruns thus if one dagrun was deleted it should have 1 row if 5 runs were deleted there should be 5. However, personally I dont mind if there will be 1 entry specifing all runs that were deleted. The issue is about serving the information less about the how. We can always improve how we serve it As for the implimitation details I think its best to review it in a PR :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
