tobiaszorzetto opened a new pull request, #36147: URL: https://github.com/apache/airflow/pull/36147
<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> <!-- Please keep an empty line above the dashes. --> This PR aims to fix the problem involving a broken regex in the function utilized for standardizing the allowed_deserialization_classes, as can be seen in issue #34093. Before these changes, class paths with `.` in the middle, such as `airflow.example`, were not matched with paths it was supposed to match. The old regex would substitute the` .` with a `\\...` and so, the path mentioned would become `airlow\\..example`. This new string would be passed as the pattern to be matched, but what it does is match the word `airflow`, followed by a literal `.`, then the second `.` would act as a wildcard to match any character, followed by the word `example`. Therefore, the original string `airflow.example` would not match this pattern, because it would be missing an extra character after the `.` and before the word `example`. For example, a class such as `airflow.texample` would match in a path such as the one given before. This error was not caught before, because the test cases didn't include paths with `.` in the middle, only in the end. In this new regex, as long as the fix explained above, The permission for all classes in a path, such as `airflow`, to be deserialized can be granted in all these different ways: ''airflow\..*', `airflow.*` and `airflow*`, maintainning the flexibility that was the goal for the PR #28829. So that these other examples could be tested and evidence for this PR could be provided, 2 new unit tests were added together with the actual code. Closes: #34093 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org