syedahsn commented on code in PR #36179: URL: https://github.com/apache/airflow/pull/36179#discussion_r1424741783
########## airflow/providers/amazon/aws/utils/exponential_backoff_retry.py: ########## @@ -0,0 +1,60 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import logging +from datetime import datetime, timedelta +from typing import Callable + +from airflow.utils import timezone + +log = logging.getLogger(__name__) + + +def exponential_backoff_retry( + last_attempt_time: datetime, + attempts_since_last_successful: int, + callable_function: Callable, + max_delay: int = 60 * 2, + max_attempts: int = -1, + exponent_base: int = 4, +) -> None: + """ + Retries a callable function with exponential backoff between attempts if it raises an exception. + + :param last_attempt_time: Timestamp of last attempt call. + :param attempts_since_last_successful: Number of attempts since last success. + :param callable_function: Callable function that will be called if enough time has passed. + :param max_delay: Maximum delay in seconds between retries. Default 120. + :param max_attempts: Maximum number of attempts before giving up. Default -1 (no limit). + :param exponent_base: Exponent base to calculate delay. Default 4. + """ + if max_attempts != -1 and attempts_since_last_successful >= max_attempts: + log.error("Max attempts reached. Exiting.") + return + + delay = min((exponent_base**attempts_since_last_successful), max_delay) + next_retry_time = last_attempt_time + timedelta(seconds=delay) + current_time = timezone.utcnow() + + if current_time >= next_retry_time: + try: + callable_function() + except Exception: + log.exception(f"Error calling {getattr(callable_function, '__name__', repr(callable_function))}") Review Comment: I agree with @o-nikolas here about keeping the exception messages visible. This error is not an error the user can ignore. The entire `sync` cycle is being skipped, so while the Executor hasn't technically gone down, it is effectively dead. In this case, I think it is ok to "spam" the logs with the exception (it not really spamming - it happens every 2 minutes, and the message is not that lengthy). The other points are good points. I'll add a new commit that addresses them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
