uranusjr commented on code in PR #36199:
URL: https://github.com/apache/airflow/pull/36199#discussion_r1425204152
##########
airflow/io/__init__.py:
##########
@@ -93,11 +93,18 @@ def get_fs(
raise ValueError(f"No filesystem registered for scheme {scheme}") from
None
options = storage_options or {}
+
# MyPy does not recognize dynamic parameters inspection when we call the
method, and we have to do
# it for compatibility reasons with already released providers, that's why
we need to ignore
# mypy errors here
parameters = inspect.signature(fs).parameters
if len(parameters) == 1:
+ if len(options) > 0:
Review Comment:
Yes since an empty dict evaluates to False
https://docs.python.org/3/library/stdtypes.html#truth-value-testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
