potiuk commented on code in PR #36205:
URL: https://github.com/apache/airflow/pull/36205#discussion_r1425659482
##########
airflow/providers/databricks/hooks/databricks_sql.py:
##########
@@ -243,11 +244,15 @@ def run(
@staticmethod
def _make_serializable(result):
- """Transform the databricks Row objects into JSON-serializable
lists."""
+ """Transform the databricks Row objects into JSON-serializable
namedtuple."""
Review Comment:
> I wonder btw if we should not have a typedef for it if this is part the
the DbAPI. That would make things conceptually stronger and less ambiguous.
Yes. It was missing from the beginning. Agree JSON in the description is
wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
