vchiapaikeo opened a new pull request, #36226:
URL: https://github.com/apache/airflow/pull/36226
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: https://github.com/apache/airflow/issues/35381
Creating a TemplatedSmtpNotifier class that simplifies sending emails based
on the discussion in https://github.com/apache/airflow/issues/35381. This class
simply extends from the SmtpNotifier and defaults a number of the required
arguments (like email_from, subject, and html_content). The latter two
variables are pulled from airflow/settings.py.
On the template itself, I was initially thinking of having at least three
distinct templates following
https://github.com/apache/airflow/issues/35381#issuecomment-1792108885 but it's
simple to add a condition to detect whether we are sending an SLA miss or a
failure/success/retry email so I decided on using a single template. Happy to
change that approach if the community thinks having distinct templates are
cleaner.
Will work on tests after the approach is generally agreed upon.
## Examples
on_failure_callback / on_success_callback / on_retry_callback -
<img width="1032" alt="Screenshot 2023-12-14 at 11 41 37 AM"
src="https://github.com/apache/airflow/assets/9200263/a36c8a17-edb0-447f-b521-32f07e3edee7";>
sla_miss_callback -
<img width="1017" alt="Screenshot 2023-12-14 at 11 42 05 AM"
src="https://github.com/apache/airflow/assets/9200263/71686fdb-1de9-44c6-af4b-4c060407f641";>
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
