ferruzzi commented on code in PR #36250:
URL: https://github.com/apache/airflow/pull/36250#discussion_r1431749360
##########
airflow/config_templates/config.yml:
##########
@@ -944,6 +944,14 @@ metrics:
description: |
StatsD (https://github.com/etsy/statsd) integration settings.
options:
+ metrics_use_fuzzy_match:
Review Comment:
@shubham22 - I'm not against the idea of deprecating but there needs to be
some kind of extra config option in the interim. If we are going to deprecate
then our best option (as I see it) is to keep `metric_allow_list` and
`metric_block_list`, add a flag to pick "old style or new style", and add a
deprecation message if that is set to "old style". Which is what I've done,
minus the message. I can add the message if we don't want to have the option
to keep the old way, but we're going to be stuck with this extra config option
until (3.0??) and then likely a bunch of confusion when the default changes
after that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
