tobiaszorzetto commented on PR #36147: URL: https://github.com/apache/airflow/pull/36147#issuecomment-1863701178
> Following @bolkedebruin's performance comment. I think we could improve caching and perforrmance much more there: > > 1. the _get_patterns should returned compiled regexps not strings > 2. _match_glob and _match_regexp could use lru_cache as well. Hey @potiuk! we have implemented these changes :). However, I'm thinking if maybe the lru_caches for the _get_patterns fuctions may be unecessary as the _match fuctions, which are the ones calling the prior mentioned, are already wrapped by the cache functions. Do you think they are still a good precaution? As I don't have much experience with the use of cache maybe I'm missing something... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
