dirrao commented on code in PR #36330:
URL: https://github.com/apache/airflow/pull/36330#discussion_r1435247103
##########
airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -255,11 +255,16 @@ def execute(self, context: Context):
return self.job_id
- def execute_complete(self, context, event=None):
+ def execute_complete(self, context: Context, event: dict[str, Any] | None
= None) -> str:
Review Comment:
I see the execute_complete function mostly same across multiple aws
operators (batch, ear, glue, crawler and etc). It's worth to re consider it
refactoring to avoid code duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
