shohamy7 commented on code in PR #34731:
URL: https://github.com/apache/airflow/pull/34731#discussion_r1435648802
##########
chart/templates/_helpers.yaml:
##########
@@ -202,50 +202,88 @@ If release name contains chart name it will be used as a
full name.
{{- if .Values.dags.gitSync.sshKeySecret }}
- name: GIT_SSH_KEY_FILE
value: "/etc/git-secret/ssh"
+ - name: GITSYNC_SSH_KEY_FILE
+ value: "/etc/git-secret/ssh"
- name: GIT_SYNC_SSH
value: "true"
+ - name: GITSYNC_SSH
+ value: "true"
{{- if .Values.dags.gitSync.knownHosts }}
- name: GIT_KNOWN_HOSTS
value: "true"
+ - name: GITSYNC_SSH_KNOWN_HOSTS
+ value: "true"
- name: GIT_SSH_KNOWN_HOSTS_FILE
value: "/etc/git-secret/known_hosts"
+ - name: GITSYNC_SSH_KNOWN_HOSTS_FILE
+ value: "/etc/git-secret/known_hosts"
{{- else }}
- name: GIT_KNOWN_HOSTS
value: "false"
+ - name: GITSYNC_SSH_KNOWN_HOSTS
+ value: "false"
{{- end }}
{{ else if .Values.dags.gitSync.credentialsSecret }}
- name: GIT_SYNC_USERNAME
valueFrom:
secretKeyRef:
name: {{ .Values.dags.gitSync.credentialsSecret | quote }}
key: GIT_SYNC_USERNAME
+ - name: GITSYNC_USERNAME
+ valueFrom:
+ secretKeyRef:
+ name: {{ .Values.dags.gitSync.credentialsSecret | quote }}
+ key: GITSYNC_USERNAME
- name: GIT_SYNC_PASSWORD
valueFrom:
secretKeyRef:
name: {{ .Values.dags.gitSync.credentialsSecret | quote }}
key: GIT_SYNC_PASSWORD
+ - name: GITSYNC_PASSWORD
+ valueFrom:
+ secretKeyRef:
+ name: {{ .Values.dags.gitSync.credentialsSecret | quote }}
+ key: GITSYNC_PASSWORD
{{- end }}
- name: GIT_SYNC_REV
value: {{ .Values.dags.gitSync.rev | quote }}
+ - name: GITSYNC_REF
+ value: {{ .Values.dags.gitSync.ref | quote }}
- name: GIT_SYNC_BRANCH
value: {{ .Values.dags.gitSync.branch | quote }}
- name: GIT_SYNC_REPO
value: {{ .Values.dags.gitSync.repo | quote }}
+ - name: GITSYNC_REPO
+ value: {{ .Values.dags.gitSync.repo | quote }}
- name: GIT_SYNC_DEPTH
value: {{ .Values.dags.gitSync.depth | quote }}
+ - name: GITSYNC_DEPTH
+ value: {{ .Values.dags.gitSync.depth | quote }}
- name: GIT_SYNC_ROOT
value: "/git"
+ - name: GITSYNC_ROOT
+ value: "/git"
- name: GIT_SYNC_DEST
value: "repo"
+ - name: GITSYNC_LINK
+ value: "repo"
- name: GIT_SYNC_ADD_USER
value: "true"
+ - name: GITSYNC_ADD_USER
+ value: "true"
- name: GIT_SYNC_WAIT
value: {{ .Values.dags.gitSync.wait | quote }}
+ - name: GITSYNC_PERIOD
+ value: {{ printf "%ss" (toString .Values.dags.gitSync.wait) | quote }}
Review Comment:
Currently, the `wait` argument is an integer type in our chart, as you can
see in our
[values.schema.json](https://github.com/apache/airflow/blob/main/chart/values.schema.json)
You can change that there to float type and add an explnantion
##########
chart/templates/_helpers.yaml:
##########
@@ -202,50 +202,88 @@ If release name contains chart name it will be used as a
full name.
{{- if .Values.dags.gitSync.sshKeySecret }}
- name: GIT_SSH_KEY_FILE
value: "/etc/git-secret/ssh"
+ - name: GITSYNC_SSH_KEY_FILE
+ value: "/etc/git-secret/ssh"
- name: GIT_SYNC_SSH
value: "true"
+ - name: GITSYNC_SSH
+ value: "true"
{{- if .Values.dags.gitSync.knownHosts }}
- name: GIT_KNOWN_HOSTS
value: "true"
+ - name: GITSYNC_SSH_KNOWN_HOSTS
+ value: "true"
- name: GIT_SSH_KNOWN_HOSTS_FILE
value: "/etc/git-secret/known_hosts"
+ - name: GITSYNC_SSH_KNOWN_HOSTS_FILE
+ value: "/etc/git-secret/known_hosts"
{{- else }}
- name: GIT_KNOWN_HOSTS
value: "false"
+ - name: GITSYNC_SSH_KNOWN_HOSTS
+ value: "false"
{{- end }}
{{ else if .Values.dags.gitSync.credentialsSecret }}
- name: GIT_SYNC_USERNAME
valueFrom:
secretKeyRef:
name: {{ .Values.dags.gitSync.credentialsSecret | quote }}
key: GIT_SYNC_USERNAME
+ - name: GITSYNC_USERNAME
+ valueFrom:
+ secretKeyRef:
+ name: {{ .Values.dags.gitSync.credentialsSecret | quote }}
+ key: GITSYNC_USERNAME
- name: GIT_SYNC_PASSWORD
valueFrom:
secretKeyRef:
name: {{ .Values.dags.gitSync.credentialsSecret | quote }}
key: GIT_SYNC_PASSWORD
+ - name: GITSYNC_PASSWORD
+ valueFrom:
+ secretKeyRef:
+ name: {{ .Values.dags.gitSync.credentialsSecret | quote }}
+ key: GITSYNC_PASSWORD
{{- end }}
- name: GIT_SYNC_REV
value: {{ .Values.dags.gitSync.rev | quote }}
+ - name: GITSYNC_REF
+ value: {{ .Values.dags.gitSync.ref | quote }}
- name: GIT_SYNC_BRANCH
value: {{ .Values.dags.gitSync.branch | quote }}
- name: GIT_SYNC_REPO
value: {{ .Values.dags.gitSync.repo | quote }}
+ - name: GITSYNC_REPO
+ value: {{ .Values.dags.gitSync.repo | quote }}
- name: GIT_SYNC_DEPTH
value: {{ .Values.dags.gitSync.depth | quote }}
+ - name: GITSYNC_DEPTH
+ value: {{ .Values.dags.gitSync.depth | quote }}
- name: GIT_SYNC_ROOT
value: "/git"
+ - name: GITSYNC_ROOT
+ value: "/git"
- name: GIT_SYNC_DEST
value: "repo"
+ - name: GITSYNC_LINK
+ value: "repo"
- name: GIT_SYNC_ADD_USER
value: "true"
+ - name: GITSYNC_ADD_USER
+ value: "true"
- name: GIT_SYNC_WAIT
value: {{ .Values.dags.gitSync.wait | quote }}
+ - name: GITSYNC_PERIOD
+ value: {{ printf "%ss" (toString .Values.dags.gitSync.wait) | quote }}
Review Comment:
Currently, the `wait` argument is an integer type in our chart, as you can
see in our
[values.schema.json](https://github.com/apache/airflow/blob/main/chart/values.schema.json)
You can change that there to float type and add an explnantion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
